Messages in this thread | | | Subject | Re: [RFC PATCH v4 2/5] ptp: Reorganize ptp_kvm modules to make it arch-independent. | From | Suzuki K Poulose <> | Date | Fri, 27 Sep 2019 11:12:03 +0100 |
| |
On 27/09/2019 11:10, Jianyong Wu (Arm Technology China) wrote: > Hi Suzuki, > >> -----Original Message----- >> From: Suzuki K Poulose <suzuki.poulose@arm.com> >> Sent: Thursday, September 26, 2019 9:06 PM >> To: Jianyong Wu (Arm Technology China) <Jianyong.Wu@arm.com>; >> netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org; >> tglx@linutronix.de; pbonzini@redhat.com; sean.j.christopherson@intel.com; >> maz@kernel.org; richardcochran@gmail.com; Mark Rutland >> <Mark.Rutland@arm.com>; Will Deacon <Will.Deacon@arm.com> >> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org; Steve Capper >> <Steve.Capper@arm.com>; Kaly Xin (Arm Technology China) >> <Kaly.Xin@arm.com>; Justin He (Arm Technology China) >> <Justin.He@arm.com>; nd <nd@arm.com> >> Subject: Re: [RFC PATCH v4 2/5] ptp: Reorganize ptp_kvm modules to make it >> arch-independent. >> >> Hi Jianyong, >> >> On 26/09/2019 12:42, Jianyong Wu wrote: >>> Currently, ptp_kvm modules implementation is only for x86 which >>> includs large part of arch-specific code. This patch move all of >>> those code into new arch related file in the same directory. >>> >>> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> >>> --- >>> drivers/ptp/Makefile | 1 + >>> drivers/ptp/{ptp_kvm.c => kvm_ptp.c} | 77 ++++++------------------ >>> drivers/ptp/ptp_kvm_x86.c | 87 >> ++++++++++++++++++++++++++++ >>> include/asm-generic/ptp_kvm.h | 12 ++++ >>> 4 files changed, 118 insertions(+), 59 deletions(-) >>> rename drivers/ptp/{ptp_kvm.c => kvm_ptp.c} (63%) >> >> minor nit: Could we not skip renaming the file ? Given you are following the >> ptp_kvm_* for the arch specific files and the header files, wouldn't it be >> good to keep ptp_kvm.c ? >> > If the module name ptp_kvm.ko is the same with its dependent object file ptp_kvm.o, warning will be given by compiler, > So I change the ptp_kvm.c to kvm_ptp.c to avoid that conflict.
Hmm, ok. How about ptp_kvm_common.c instead of kvm_ptp.c ?
Suzuki
| |