Messages in this thread | | | Date | Fri, 27 Sep 2019 10:24:54 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC |
| |
On Thu, Sep 26, 2019 at 10:43:38PM +0100, Vincenzo Frascino wrote: > Address the problem removing CONFIG_CROSS_COMPILE_COMPAT_VDSO and moving
And this config does need to go in a subsequent patch.
> the detection of the correct compiler into Kconfig via COMPAT_CC_IS_GCC.
Nitpick: it's COMPATCC_IS_ARM_GCC now.
> As a consequence of this it is not possible anymore to set the compat > cross compiler from menuconfig but it requires to be exported via > command line. > > E.g.: > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- > CROSS_COMPILE_COMPAT=arm-linux-gnueabihf
Another nitpick, add a '-' at the end of 'gnueabihf'.
Otherwise:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
| |