Messages in this thread |  | | Subject | Re: [RFC PATCH v4 2/5] ptp: Reorganize ptp_kvm modules to make it arch-independent. | From | Suzuki K Poulose <> | Date | Thu, 26 Sep 2019 14:06:12 +0100 |
| |
Hi Jianyong,
On 26/09/2019 12:42, Jianyong Wu wrote: > Currently, ptp_kvm modules implementation is only for x86 which includs > large part of arch-specific code. This patch move all of those code > into new arch related file in the same directory. > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> > --- > drivers/ptp/Makefile | 1 + > drivers/ptp/{ptp_kvm.c => kvm_ptp.c} | 77 ++++++------------------ > drivers/ptp/ptp_kvm_x86.c | 87 ++++++++++++++++++++++++++++ > include/asm-generic/ptp_kvm.h | 12 ++++ > 4 files changed, 118 insertions(+), 59 deletions(-) > rename drivers/ptp/{ptp_kvm.c => kvm_ptp.c} (63%)
minor nit: Could we not skip renaming the file ? Given you are following the ptp_kvm_* for the arch specific files and the header files, wouldn't it be good to keep ptp_kvm.c ?
Rest looks fine.
Cheers Suzuki
|  |