Messages in this thread | | | Subject | Re: [PATCH v2 3/3] reset: add support for the Meson-A1 SoC Reset Controller | From | Xingyu Chen <> | Date | Thu, 26 Sep 2019 11:44:25 +0800 |
| |
Hi, Kevin Thanks for your reminder
On 2019/9/26 6:57, Kevin Hilman wrote: > Hi Xingyu, > > Xingyu Chen <xingyu.chen@amlogic.com> writes: > >> The number of RESET registers and offset of RESET_LEVEL register for >> Meson-A1 are different from previous SoCs, In order to describe these >> differences, we introduce the struct meson_reset_param. >> >> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com> >> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> >> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > > Again, order here isn't quite right. Add the reviewed-by tags first, > and the sender should be the last sign-off. I will reorder Signed-off and Reviewed in next version > > Other than that, driver looks good. > > Reviewed-by: Kevin Hilman <khilman@baylibre.com > > Kevin > > . >
| |