Messages in this thread | | | Date | Thu, 26 Sep 2019 00:50:05 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v10 07/12] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms" |
| |
On Wed, Sep 25, 2019 at 10:32:32PM +0800, Sam Shih wrote: > From: Ryder Lee <ryder.lee@mediatek.com> > > This adds a property "num-pwms" in example so that we could > specify the number of PWM channels via device tree. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > Signed-off-by: Sam Shih <sam.shih@mediatek.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since v10: > 1. Follow reviewers's comments: > - derive the number of PWMs from the specific compatible string [...] > + - num-pwms: the number of PWM channels. [...]
Why is num-pwms still there if you derive it from the compatible string? I guess I must not have made myself clear. Please drop this.
Also, as I mentioned earlier, I've already applied the patches from v9 that were suitable. Please take a look.
Thierry [unhandled content-type:application/pgp-signature] | |