Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [RFC PATCH 2/4] iommu/vt-d: Add first level page table interfaces | Date | Wed, 25 Sep 2019 04:38:31 +0000 |
| |
> From: Peter Xu [mailto:peterx@redhat.com] > Sent: Wednesday, September 25, 2019 12:31 PM > > On Tue, Sep 24, 2019 at 09:38:53AM +0800, Lu Baolu wrote: > > > > intel_mmmap_range(domain, addr, end, phys_addr, prot) > > > > > > Maybe think of a different name..? mmmap seems a bit weird :-) > > > > Yes. I don't like it either. I've thought about it and haven't > > figured out a satisfied one. Do you have any suggestions? > > How about at least split the word using "_"? Like "mm_map", then > apply it to all the "mmm*" prefixes. Otherwise it'll be easily > misread as mmap() which is totally irrelevant to this... >
what is the point of keeping 'mm' here? replace it with 'iommu'?
Thanks Kevin
| |