lkml.org 
[lkml]   [2019]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework
    Date
    Hi John,

    On Fri, Sep 06, 2019 at 06:47:08PM +0000, John Stultz wrote:
    > From: "Andrew F. Davis" <afd@ti.com>
    >
    > This framework allows a unified userspace interface for dma-buf
    > exporters, allowing userland to allocate specific types of memory
    > for use in dma-buf sharing.
    >
    > Each heap is given its own device node, which a user can allocate
    > a dma-buf fd from using the DMA_HEAP_IOC_ALLOC.
    >
    > This code is an evoluiton of the Android ION implementation,
    > and a big thanks is due to its authors/maintainers over time
    > for their effort:
    > Rebecca Schultz Zavin, Colin Cross, Benjamin Gaignard,
    > Laura Abbott, and many other contributors!
    >
    > Cc: Laura Abbott <labbott@redhat.com>
    > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
    > Cc: Sumit Semwal <sumit.semwal@linaro.org>
    > Cc: Liam Mark <lmark@codeaurora.org>
    > Cc: Pratik Patel <pratikp@codeaurora.org>
    > Cc: Brian Starkey <Brian.Starkey@arm.com>
    > Cc: Vincent Donnefort <Vincent.Donnefort@arm.com>
    > Cc: Sudipto Paul <Sudipto.Paul@arm.com>
    > Cc: Andrew F. Davis <afd@ti.com>
    > Cc: Christoph Hellwig <hch@infradead.org>
    > Cc: Chenbo Feng <fengc@google.com>
    > Cc: Alistair Strachan <astrachan@google.com>
    > Cc: Hridya Valsaraju <hridya@google.com>
    > Cc: dri-devel@lists.freedesktop.org
    > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
    > Signed-off-by: Andrew F. Davis <afd@ti.com>
    > Signed-off-by: John Stultz <john.stultz@linaro.org>

    One miniscule nit from me below, but whether you change it or not, you
    can add my r-b:

    Reviewed-by: Brian Starkey <brian.starkey@arm.com>

    Thanks for pushing this through!

    -Brian

    > ---

    ...

    > +
    > + dev_ret = device_create(dma_heap_class,
    > + NULL,
    > + heap->heap_devt,
    > + NULL,
    > + heap->name);
    > + if (IS_ERR(dev_ret)) {
    > + pr_err("dma_heap: Unable to create device\n");
    > + err_ret = (struct dma_heap *)dev_ret;

    Tiny nit: ERR_CAST() would be more obvious for me here.

    \
     
     \ /
      Last update: 2019-09-24 00:10    [W:4.264 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site