lkml.org 
[lkml]   [2019]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 125/128] media: ttusb-dec: Fix info-leak in ttusb_dec_send_command()
    Date
    From: Tomas Bortoli <tomasbortoli@gmail.com>

    [ Upstream commit a10feaf8c464c3f9cfdd3a8a7ce17e1c0d498da1 ]

    The function at issue does not always initialize each byte allocated
    for 'b' and can therefore leak uninitialized memory to a USB device in
    the call to usb_bulk_msg()

    Use kzalloc() instead of kmalloc()

    Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
    Reported-by: syzbot+0522702e9d67142379f1@syzkaller.appspotmail.com
    Signed-off-by: Sean Young <sean@mess.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/usb/ttusb-dec/ttusb_dec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/usb/ttusb-dec/ttusb_dec.c b/drivers/media/usb/ttusb-dec/ttusb_dec.c
    index 44ca66cb9b8f1..f34efa7c61b40 100644
    --- a/drivers/media/usb/ttusb-dec/ttusb_dec.c
    +++ b/drivers/media/usb/ttusb-dec/ttusb_dec.c
    @@ -329,7 +329,7 @@ static int ttusb_dec_send_command(struct ttusb_dec *dec, const u8 command,

    dprintk("%s\n", __func__);

    - b = kmalloc(COMMAND_PACKET_SIZE + 4, GFP_KERNEL);
    + b = kzalloc(COMMAND_PACKET_SIZE + 4, GFP_KERNEL);
    if (!b)
    return -ENOMEM;

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-09-22 21:14    [W:4.031 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site