lkml.org 
[lkml]   [2019]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 46/60] md/raid1: fail run raid1 array when active disk less than one
    Date
    From: Yufen Yu <yuyufen@huawei.com>

    [ Upstream commit 07f1a6850c5d5a65c917c3165692b5179ac4cb6b ]

    When run test case:
    mdadm -CR /dev/md1 -l 1 -n 4 /dev/sd[a-d] --assume-clean --bitmap=internal
    mdadm -S /dev/md1
    mdadm -A /dev/md1 /dev/sd[b-c] --run --force

    mdadm --zero /dev/sda
    mdadm /dev/md1 -a /dev/sda

    echo offline > /sys/block/sdc/device/state
    echo offline > /sys/block/sdb/device/state
    sleep 5
    mdadm -S /dev/md1

    echo running > /sys/block/sdb/device/state
    echo running > /sys/block/sdc/device/state
    mdadm -A /dev/md1 /dev/sd[a-c] --run --force

    mdadm run fail with kernel message as follow:
    [ 172.986064] md: kicking non-fresh sdb from array!
    [ 173.004210] md: kicking non-fresh sdc from array!
    [ 173.022383] md/raid1:md1: active with 0 out of 4 mirrors
    [ 173.022406] md1: failed to create bitmap (-5)

    In fact, when active disk in raid1 array less than one, we
    need to return fail in raid1_run().

    Reviewed-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Yufen Yu <yuyufen@huawei.com>
    Signed-off-by: Song Liu <songliubraving@fb.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/md/raid1.c | 13 ++++++++++++-
    1 file changed, 12 insertions(+), 1 deletion(-)

    diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
    index 53048bf0b2b81..9892c41de4419 100644
    --- a/drivers/md/raid1.c
    +++ b/drivers/md/raid1.c
    @@ -2960,6 +2960,13 @@ static int raid1_run(struct mddev *mddev)
    !test_bit(In_sync, &conf->mirrors[i].rdev->flags) ||
    test_bit(Faulty, &conf->mirrors[i].rdev->flags))
    mddev->degraded++;
    + /*
    + * RAID1 needs at least one disk in active
    + */
    + if (conf->raid_disks - mddev->degraded < 1) {
    + ret = -EINVAL;
    + goto abort;
    + }

    if (conf->raid_disks - mddev->degraded == 1)
    mddev->recovery_cp = MaxSector;
    @@ -2994,8 +3001,12 @@ static int raid1_run(struct mddev *mddev)
    ret = md_integrity_register(mddev);
    if (ret) {
    md_unregister_thread(&mddev->thread);
    - raid1_free(mddev, conf);
    + goto abort;
    }
    + return 0;
    +
    +abort:
    + raid1_free(mddev, conf);
    return ret;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-09-22 21:06    [W:6.084 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site