lkml.org 
[lkml]   [2019]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 50/60] irqchip/gic-v3-its: Fix LPI release for Multi-MSI devices
    Date
    From: Marc Zyngier <maz@kernel.org>

    [ Upstream commit c9c96e30ecaa0aafa225aa1a5392cb7db17c7a82 ]

    When allocating a range of LPIs for a Multi-MSI capable device,
    this allocation extended to the closest power of 2.

    But on the release path, the interrupts are released one by
    one. This results in not releasing the "extra" range, leaking
    the its_device. Trying to reprobe the device will then fail.

    Fix it by releasing the LPIs the same way we allocate them.

    Fixes: 8208d1708b88 ("irqchip/gic-v3-its: Align PCI Multi-MSI allocation on their size")
    Reported-by: Jiaxing Luo <luojiaxing@huawei.com>
    Tested-by: John Garry <john.garry@huawei.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/f5e948aa-e32f-3f74-ae30-31fee06c2a74@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/irqchip/irq-gic-v3-its.c | 9 ++++-----
    1 file changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
    index 83ca754250fb7..0c0cd2768d6e9 100644
    --- a/drivers/irqchip/irq-gic-v3-its.c
    +++ b/drivers/irqchip/irq-gic-v3-its.c
    @@ -1519,14 +1519,13 @@ static void its_irq_domain_free(struct irq_domain *domain, unsigned int virq,
    struct its_device *its_dev = irq_data_get_irq_chip_data(d);
    int i;

    + bitmap_release_region(its_dev->event_map.lpi_map,
    + its_get_event_id(irq_domain_get_irq_data(domain, virq)),
    + get_count_order(nr_irqs));
    +
    for (i = 0; i < nr_irqs; i++) {
    struct irq_data *data = irq_domain_get_irq_data(domain,
    virq + i);
    - u32 event = its_get_event_id(data);
    -
    - /* Mark interrupt index as unused */
    - clear_bit(event, its_dev->event_map.lpi_map);
    -
    /* Nuke the entry in the domain */
    irq_domain_reset_irq_data(data);
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-09-22 21:03    [W:3.632 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site