Messages in this thread | | | Date | Fri, 20 Sep 2019 21:13:50 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 2/2] net/phy/mdio-mscc-miim: Move the setting of mii_bus structure members in mscc_miim_probe() |
| |
On Fri, Sep 20, 2019 at 09:03:57PM +0200, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 20 Sep 2019 20:42:42 +0200 > > Move the modification of some members in the data structure “mii_bus” > for the local variable “bus” directly before the call of > the function “of_mdiobus_register” so that this change will be performed > only after previous resource allocations succeeded.
Hi Markus
I'm not sure it is worth making this change. The resource allocations succeeds 99.9999% of the time. It is a chunk of MMIO, not some gpio, or i2c device which might give us EPROBE_DEFERRED. So we are not wasting anything in reality.
Andrew
| |