lkml.org 
[lkml]   [2019]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 048/132] fuse: fallocate: fix return with locked inode
    3.16.74-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Miklos Szeredi <mszeredi@redhat.com>

    commit 35d6fcbb7c3e296a52136347346a698a35af3fda upstream.

    Do the proper cleanup in case the size check fails.

    Tested with xfstests:generic/228

    Reported-by: kbuild test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Fixes: 0cbade024ba5 ("fuse: honor RLIMIT_FSIZE in fuse_file_fallocate")
    Cc: Liu Bo <bo.liu@linux.alibaba.com>
    Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/fuse/file.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/fuse/file.c
    +++ b/fs/fuse/file.c
    @@ -3021,7 +3021,7 @@ static long fuse_file_fallocate(struct f
    offset + length > i_size_read(inode)) {
    err = inode_newsize_ok(inode, offset + length);
    if (err)
    - return err;
    + goto out;
    }

    if (!(mode & FALLOC_FL_KEEP_SIZE))
    \
     
     \ /
      Last update: 2019-09-20 16:30    [W:4.512 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site