Messages in this thread | | | Date | Fri, 20 Sep 2019 11:51:01 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] spi: atmel: Fix crash when using more than 4 gpio CS |
| |
On Thu, Sep 19, 2019 at 07:23:50PM +0200, Alexandre Belloni wrote: > On 19/09/2019 17:03:15+0100, Mark Brown wrote:
> > This is going to break any system where we use both a GPIO chip select > > and chip select 0. Ideally we'd try to figure out an unused chip select > > to use here...
> The point is that this use case is already broken and this patch fixes > the crash and is easily backportable.
> Fixing the CS + gpio CS should probably be done in a separate patch.
If the GPIO is overlaid on any of the existing slots (except GPIO 0) then it'll cause GPIO 0 to start toggling. I'm not convinced that the code doesn't currently support that. [unhandled content-type:application/pgp-signature] | |