Messages in this thread | | | Date | Fri, 20 Sep 2019 10:47:53 +0200 | From | Tycho Andersen <> | Subject | Re: [PATCH v2 2/3] seccomp: avoid overflow in implicit constant conversion |
| |
On Fri, Sep 20, 2019 at 10:30:06AM +0200, Christian Brauner wrote: > USER_NOTIF_MAGIC is assigned to int variables in this test so set it to INT_MAX > to avoid warnings: > > seccomp_bpf.c: In function ‘user_notification_continue’: > seccomp_bpf.c:3088:26: warning: overflow in implicit constant conversion [-Woverflow] > #define USER_NOTIF_MAGIC 116983961184613L > ^ > seccomp_bpf.c:3572:15: note: in expansion of macro ‘USER_NOTIF_MAGIC’ > resp.error = USER_NOTIF_MAGIC; > ^~~~~~~~~~~~~~~~ > > Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace") > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> > Reviewed-by: Tyler Hicks <tyhicks@canonical.com> > Cc: Kees Cook <keescook@chromium.org> > Cc: Andy Lutomirski <luto@amacapital.net> > Cc: Will Drewry <wad@chromium.org> > Cc: Shuah Khan <shuah@kernel.org> > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: Martin KaFai Lau <kafai@fb.com> > Cc: Song Liu <songliubraving@fb.com> > Cc: Yonghong Song <yhs@fb.com> > Cc: Tycho Andersen <tycho@tycho.ws>
You can also add,
Reviewed-by: Tycho Andersen <tycho@tycho.ws>
for this one.
Tycho
| |