Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 20 Sep 2019 09:42:51 +0200 | Subject | Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K |
| |
On Fri, Sep 20, 2019 at 7:51 AM Joel Stanley <joel@jms.id.au> wrote: > On Thu, 19 Sep 2019 at 14:27, Arnd Bergmann <arnd@arndb.de> wrote:
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > arch/arm/mach-aspeed/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig > > index a293137f5814..163931a03136 100644 > > --- a/arch/arm/mach-aspeed/Kconfig > > +++ b/arch/arm/mach-aspeed/Kconfig > > @@ -26,7 +26,6 @@ config MACH_ASPEED_G4 > > config MACH_ASPEED_G5 > > bool "Aspeed SoC 5th Generation" > > depends on ARCH_MULTI_V6 > > - select CPU_V6 > > select PINCTRL_ASPEED_G5 if !CC_IS_CLANG > > I can't find any trees with !CC_IS_CLANG here. Is there a problem > building our pinmux driver with Clang?
This was an unrelated change from my local randconfig tree.
Your driver uncovered a bug in clang that is now fixed, the driver itself is fine, see https://bugs.llvm.org/show_bug.cgi?id=43243
> I tested with this patch: > --- a/arch/arm/mach-aspeed/Kconfig > +++ b/arch/arm/mach-aspeed/Kconfig > @@ -25,8 +25,8 @@ config MACH_ASPEED_G4 > > config MACH_ASPEED_G5 > bool "Aspeed SoC 5th Generation" > + # This implies ARMv6K which covers the ARM1176 > depends on ARCH_MULTI_V6 > - select CPU_V6 > select PINCTRL_ASPEED_G5 > select FTTMR010_TIMER > help > > If you want to apply that as a fix for 5.4 I would be happy with that. > > Fixes: 8c2ed9bcfbeb ("arm: Add Aspeed machine") > Reviewed-by: Joel Stanley <joel@jms.id.au>
Applied to arm/fixes now.
Arnd
| |