Messages in this thread | | | From | Tal Gilboa <> | Subject | Re: dimlib: should it really be enabled by default? [Was: [PATCH] trivial: lib/Kconfig: typo modertion -> moderation] | Date | Fri, 20 Sep 2019 07:40:45 +0000 |
| |
On 9/20/2019 12:07 AM, Uwe Kleine-König wrote: > On 9/19/19 11:03 PM, Uwe Kleine-König wrote: >> Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") >> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> >> --- >> lib/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/Kconfig b/lib/Kconfig >> index 4e6b1c3e4c98..cc04124ed8f7 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -559,7 +559,7 @@ config DIMLIB >> default y > > BTW, I wonder about this "default y". I see there are some drivers that > select DIMLIB, so I wonder if I benefit from it at all if I don't use > such a driver?!
Thanks for bringing this up. The only benefit from DIM comes from a driver that use it. I don't mind the default would be changed but from what I see not all drivers that use DIM have the select DIMLIB line in their Kconfig files, so such a change should make sure no functionality is broken.
> > Best regards > Uwe
| |