lkml.org 
[lkml]   [2019]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iwlwifi: fix a potential NULL pointer dereference
From
Date
On Thu, 2019-09-19 at 19:37 +0530, Allen wrote:
> >
> > + trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
> > + WQ_HIGHPRI | WQ_UNBOUND, 1);
> > + if (!trans_pcie->rba.alloc_wq) {
>
> I would like to stick to if(unlikely(!trans_pcie->rba.alloc_wq) just
> for consistency.

That's just clutter, this path gets called exactly once in the lifetime
of most systems ...

> Let me know if I could add your SOB and send out V2.

No no, I've already sent the patch on the way internally :)

johannes

\
 
 \ /
  Last update: 2019-09-19 16:48    [W:0.060 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site