Messages in this thread | | | Subject | Re: [PATCH trivial] KVM: PPC: Remove superfluous check for non-zero return value | From | Thomas Huth <> | Date | Thu, 19 Sep 2019 07:51:27 +0200 |
| |
On 18/09/2019 22.54, Greg Kurz wrote: > On Wed, 18 Sep 2019 18:44:36 +0200 > Greg Kurz <groug@kaod.org> wrote: > >> On Wed, 11 Sep 2019 21:52:35 +0200 >> Thomas Huth <thuth@redhat.com> wrote: >> >>> After the kfree()s haven been removed in the previous >>> commit 9798f4ea71ea ("fix rollback when kvmppc_xive_create fails"), >>> the code can be simplified even more to simply always "return ret" >>> now. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>> --- >> >> This looks like a good candidate for trivial, hence Cc'ing Jiri >> and adding trivial keyword in subject. >> >> Reviewed-by: Greg Kurz <groug@kaod.org> >> > > Oops, the patch is correct but there are some fixes that require > the return 0 to stay around... > > https://patchwork.ozlabs.org/project/kvm-ppc/list/?series=129957
:-)
Ok, then please simply ignore my patch.
Thomas
| |