Messages in this thread | | | Date | Thu, 19 Sep 2019 10:10:59 +0200 (CEST) | Subject | Re: [PATCH v2] net: dsa: sja1105: prevent leaking memory | From | David Miller <> |
| |
From: Vladimir Oltean <olteanv@gmail.com> Date: Wed, 18 Sep 2019 23:00:20 +0300
> Hi Navid, > > Thanks for the patch. > > On 9/18/19 9:04 PM, Navid Emamdoost wrote: >> In sja1105_static_config_upload, in two cases memory is leaked: when >> static_config_buf_prepare_for_upload fails and when sja1105_inhibit_tx >> fails. In both cases config_buf should be released. >> Fixes: 8aa9ebccae876 (avoid leaking config_buf) >> Fixes: 1a4c69406cc1c (avoid leaking config_buf) >> > > You're not supposed to add a short description of the patch here, but > rather the commit message of the patch you're fixing. > Add this to your ~/.gitconfig: > > [pretty] > fixes = Fixes: %h (\"%s\") > > And then run: > git show --pretty=fixes 8aa9ebccae87621d997707e4f25e53fddd7e30e4 > > Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 > 5-port L2 switch") > > git show --pretty=fixes 1a4c69406cc1c3c42bb7391c8eb544e93fe9b320 > > Fixes: 1a4c69406cc1 ("net: dsa: sja1105: Prevent PHY jabbering during > switch reset")
However the Fixes: line should not be broken up like this with newlines.
| |