lkml.org 
[lkml]   [2019]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 29/45] clk: rockchip: Dont yell about bad mmc phases when getting
    Date
    From: Douglas Anderson <dianders@chromium.org>

    commit 6943b839721ad4a31ad2bacf6e71b21f2dfe3134 upstream.

    At boot time, my rk3288-veyron devices yell with 8 lines that look
    like this:
    [ 0.000000] rockchip_mmc_get_phase: invalid clk rate

    This is because the clock framework at clk_register() time tries to
    get the phase but we don't have a parent yet.

    While the errors appear to be harmless they are still ugly and, in
    general, we don't want yells like this in the log unless they are
    important.

    There's no real reason to be yelling here. We can still return
    -EINVAL to indicate that the phase makes no sense without a parent.
    If someone really tries to do tuning and the clock is reported as 0
    then we'll see the yells in rockchip_mmc_set_phase().

    Fixes: 4bf59902b500 ("clk: rockchip: Prevent calculating mmc phase if clock rate is zero")
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    Signed-off-by: Heiko Stuebner <heiko@sntech.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/clk/rockchip/clk-mmc-phase.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/clk/rockchip/clk-mmc-phase.c
    +++ b/drivers/clk/rockchip/clk-mmc-phase.c
    @@ -59,10 +59,8 @@ static int rockchip_mmc_get_phase(struct
    u32 delay_num = 0;

    /* See the comment for rockchip_mmc_set_phase below */
    - if (!rate) {
    - pr_err("%s: invalid clk rate\n", __func__);
    + if (!rate)
    return -EINVAL;
    - }

    raw_value = readl(mmc_clock->reg) >> (mmc_clock->shift);


    \
     
     \ /
      Last update: 2019-09-18 08:33    [W:2.339 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site