lkml.org 
[lkml]   [2019]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 74/85] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"
    Date
    From: Mario Limonciello <mario.limonciello@dell.com>

    commit 1ffdb51f28e8ec6be0a2b812c1765b5cf5c44a8f upstream.

    This reverts commit a0085f2510e8976614ad8f766b209448b385492f.

    This commit has caused regressions in notebooks that support suspend
    to idle such as the XPS 9360, XPS 9370 and XPS 9380.

    These notebooks will wakeup from suspend to idle from an unsolicited
    advertising packet from an unpaired BLE device.

    In a bug report it was sugggested that this is caused by a generic
    lack of LE privacy support. Revert this commit until that behavior
    can be avoided by the kernel.

    Fixes: a0085f2510e8 ("Bluetooth: btusb: driver to enable the usb-wakeup feature")
    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=200039
    Link: https://marc.info/?l=linux-bluetooth&m=156441081612627&w=2
    Link: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/750073/
    CC: Bastien Nocera <hadess@hadess.net>
    CC: Christian Kellner <ckellner@redhat.com>
    CC: Sukumar Ghorai <sukumar.ghorai@intel.com>
    Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/bluetooth/btusb.c | 5 -----
    1 file changed, 5 deletions(-)

    --- a/drivers/bluetooth/btusb.c
    +++ b/drivers/bluetooth/btusb.c
    @@ -1162,10 +1162,6 @@ static int btusb_open(struct hci_dev *hd
    }

    data->intf->needs_remote_wakeup = 1;
    - /* device specific wakeup source enabled and required for USB
    - * remote wakeup while host is suspended
    - */
    - device_wakeup_enable(&data->udev->dev);

    if (test_and_set_bit(BTUSB_INTR_RUNNING, &data->flags))
    goto done;
    @@ -1229,7 +1225,6 @@ static int btusb_close(struct hci_dev *h
    goto failed;

    data->intf->needs_remote_wakeup = 0;
    - device_wakeup_disable(&data->udev->dev);
    usb_autopm_put_interface(data->intf);

    failed:

    \
     
     \ /
      Last update: 2019-09-18 08:29    [W:4.043 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site