Messages in this thread | | | Subject | Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument | From | shuah <> | Date | Wed, 18 Sep 2019 15:05:33 -0600 |
| |
On 9/18/19 5:33 AM, Eugeniu Rosca wrote: > Hi Shuah, > > On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote: >> From: "George G. Davis" <george_davis@mentor.com> >> >> The newly added optional file argument does not validate if the >> file is indeed a watchdog, e.g.: >> >> ./watchdog-test -f /dev/zero >> Watchdog Ticking Away! >> >> Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds. >> >> Fixes: c3f2490d6e9257 ("selftests: watchdog: Add optional file argument") >> Reported-by: Eugeniu Rosca <erosca@de.adit-jv.com> >> Signed-off-by: George G. Davis <george_davis@mentor.com> >> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> >> --- >> v3: >> - Used v1 as starting point and simplified commit description >> - Added Fixes tag (WARNING: commit id is from linux-next!) >> - No change in the contents >> - Applied cleanly to the same base as used in [v1] > > Can we have your confirmation the patches look fine now? >
Hi Eugeniu,
They both look good to me. I will apply these patches once the merge window closes or when my first pull request to Linus clears.
You will see a notification when I apply them to kselftest tree.
thanks, -- Shuah
| |