Messages in this thread | | | Date | Mon, 16 Sep 2019 09:12:20 +0200 (CEST) | Subject | Re: [PATCH net] net: stmmac: Hold rtnl lock in suspend/resume callbacks | From | David Miller <> |
| |
From: Jose Abreu <Jose.Abreu@synopsys.com> Date: Fri, 13 Sep 2019 11:50:32 +0200
> We need to hold rnl lock in suspend and resume callbacks because phylink > requires it. Otherwise we will get a WARN() in suspend and resume. > > Also, move phylink start and stop callbacks to inside device's internal > lock so that we prevent concurrent HW accesses. > > Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") > Reported-by: Christophe ROULLIER <christophe.roullier@st.com> > Tested-by: Christophe ROULLIER <christophe.roullier@st.com> > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Applied and queued up for v5.3 -stable.
Thanks.
| |