lkml.org 
[lkml]   [2019]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 6/9] leds: multicolor: Introduce a multicolor class definition
From
Date
Jacek

On 9/15/19 11:20 AM, Jacek Anaszewski wrote:
>
>> +
>> +static int led_multicolor_init_color(struct led_classdev_mc_data *data,
>> + struct led_classdev_mc *mcled_cdev,
>> + int color_id, int color_index)
>> +{
>> + struct led_classdev *led_cdev = mcled_cdev->led_cdev;
>> + struct led_classdev_mc_priv *mc_priv;
>> + int ret;
>> +
>> + mc_priv = devm_kzalloc(led_cdev->dev, sizeof(*mc_priv), GFP_KERNEL);
>> + if (!mc_priv)
>> + return -ENOMEM;
>> +
>> + mc_priv->led_color_id = color_id;
>> + mc_priv->mcled_cdev = mcled_cdev;
>> +
>> + data->led_kobj = kobject_create_and_add(led_colors[color_id],
>> + data->color_kobj);
> No change here since previous version? What prevents you from following
> what has been done for drivers/usb/core/ledtrig-usbport.c?
>
> Use sysfs_create_group() for creating color dir
> and sysfs_add_file_to_group() for adding files to it.

We have nested directories here.  colors is a directory and then the LED
color is a directory.

So I am not sure how to create a group under another group without the
colors directory kobj.

Wondering if you know of any examples?

Dan

\
 
 \ /
  Last update: 2019-09-16 20:34    [W:0.049 / U:16.088 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site