lkml.org 
[lkml]   [2019]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] selftests: watchdog: Validate optional file argument
    Hi Shuah,

    On Sat, Sep 07, 2019 at 10:58:32AM +0200, Eugeniu Rosca wrote:
    > From: "George G. Davis" <george_davis@mentor.com>
    >
    > As reported by Eugeniu Rosca, the newly added optional file
    > argument does not validate if the file is indeed a watchdog, e.g.:
    >
    > ./watchdog-test -f /dev/zero
    > Watchdog Ticking Away!
    >
    > Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds.
    >
    > Reported-by: Eugeniu Rosca <erosca@de.adit-jv.com>
    > Signed-off-by: George G. Davis <george_davis@mentor.com>
    > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
    > ---
    > v1: Applied/tested on commit ce54eab71e210f ("kunit: fix failure to build without printk") of
    > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next

    Any concerns about the two patches?
    Can you please confirm they are in your queue?

    --
    Best Regards,
    Eugeniu.

    \
     
     \ /
      Last update: 2019-09-16 14:09    [W:4.330 / U:1.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site