Messages in this thread | | | Subject | Re: [PATCH 4/4] coding-style: add explanation about pr_fmt macro | From | Joe Perches <> | Date | Fri, 13 Sep 2019 12:08:39 -0700 |
| |
On Fri, 2019-09-13 at 15:57 -0300, André Almeida wrote: > The pr_fmt macro is useful to format log messages printed by pr_XXXX() > functions. Add text to explain the purpose of it, how to use and an > example. [] > diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst [] > @@ -819,7 +819,15 @@ which you should use to make sure messages are matched to the right device > and driver, and are tagged with the right level: dev_err(), dev_warn(), > dev_info(), and so forth. For messages that aren't associated with a > particular device, <linux/printk.h> defines pr_notice(), pr_info(), > -pr_warn(), pr_err(), etc. > +pr_warn(), pr_err(), etc. It's possible to format pr_XXX() messages using the > +macro pr_fmt() to prevent rewriting the style of messages. It should be > +defined before including ``include/printk.h``, to avoid compiler warning about
Please make this '#include <linux/kernel.h>'
printk.h should normally not be #included.
| |