lkml.org 
[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
From
Date
On Fri, 2019-09-13 at 10:22 -0400, Alan Stern wrote:
> On Thu, 12 Sep 2019, Joe Perches wrote:
>
> > On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> > > checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> > > nominal patch author" if there is no nominal patch author. Without
> > > this change, checkpatch always gives me the following warning:
> > >
> > > WARNING: Missing Signed-off-by: line by nominal patch author ''
> >
> > When/how does this occur? Example please.
>
> The patch itself is a good example. Attached to this email is the
> patch file in the form I keep it (from quilt, not git; note that quilt
> doesn't do a good job of handling the "---" line so I leave it out and
> insert it when submitting the patch). Try saving the attachment and
> running it through checkpatch.pl. Here's what I get:

Andrew?

Does checkpatch emit this warning for you on
your quilt content?

If so, how do you handle it?

> $ scripts/checkpatch.pl /tmp/checkpatch-author-fix.patch
> WARNING: Missing Signed-off-by: line by nominal patch author ''
>
> total: 0 errors, 1 warnings, 8 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> /tmp/checkpatch-author-fix.patch has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> Would you like me to resubmit the patch with this example added to the
> patch description?
>
> Alan Stern

\
 
 \ /
  Last update: 2019-09-13 17:36    [W:0.075 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site