lkml.org 
[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 168/190] ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips
    Date
    [ Upstream commit 2756d9143aa517b97961e85412882b8ce31371a6 ]

    It turned out that the recent Intel HD-audio controller chips show a
    significant stall during the system PM resume intermittently. It
    doesn't happen so often and usually it may read back successfully
    after one or more seconds, but in some rare worst cases the driver
    went into fallback mode.

    After trial-and-error, we found out that the communication stall seems
    covered by issuing the sync after each verb write, as already done for
    AMD and other chipsets. So this patch enables the write-sync flag for
    the recent Intel chips, Skylake and onward, as a workaround.

    Also, since Broxton and co have the very same driver flags as Skylake,
    refer to the Skylake driver flags instead of defining the same
    contents again for simplification.

    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201901
    Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/pci/hda/hda_intel.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
    index 7a3e34b120b33..c3e3d80ff7203 100644
    --- a/sound/pci/hda/hda_intel.c
    +++ b/sound/pci/hda/hda_intel.c
    @@ -329,13 +329,11 @@ enum {

    #define AZX_DCAPS_INTEL_SKYLAKE \
    (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\
    + AZX_DCAPS_SYNC_WRITE |\
    AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT |\
    AZX_DCAPS_I915_POWERWELL)

    -#define AZX_DCAPS_INTEL_BROXTON \
    - (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\
    - AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT |\
    - AZX_DCAPS_I915_POWERWELL)
    +#define AZX_DCAPS_INTEL_BROXTON AZX_DCAPS_INTEL_SKYLAKE

    /* quirks for ATI SB / AMD Hudson */
    #define AZX_DCAPS_PRESET_ATI_SB \
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-09-13 15:21    [W:2.222 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site