Messages in this thread | | | From | Sami Tolvanen <> | Date | Fri, 13 Sep 2019 16:26:37 -0700 | Subject | Re: [PATCH 3/4] x86: use the correct function type for sys_ni_syscall |
| |
On Fri, Sep 13, 2019 at 3:45 PM Andy Lutomirski <luto@kernel.org> wrote: > Should this be SYSCALL_DEFINE0?
It can be, and that would also fix the issue. However, it does result in unnecessary error injection to be hooked up here, which is why arm64 preferred to avoid the macro when I fixed it there. S390 uses SYSCALL_DEFINE0 for this though and since sys_ni_syscall always returns -ENOSYS, it shouldn't be a huge problem. Thoughts?
Sami
| |