lkml.org 
[lkml]   [2019]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
    checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
    nominal patch author" if there is no nominal patch author. Without
    this change, checkpatch always gives me the following warning:

    WARNING: Missing Signed-off-by: line by nominal patch author ''

    Signed-off-by: Alan Stern <stern@rowland.harvard.edu>

    ---

    scripts/checkpatch.pl | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: usb-devel/scripts/checkpatch.pl
    ===================================================================
    --- usb-devel.orig/scripts/checkpatch.pl
    +++ usb-devel/scripts/checkpatch.pl
    @@ -6673,7 +6673,7 @@ sub process {
    if ($signoff == 0) {
    ERROR("MISSING_SIGN_OFF",
    "Missing Signed-off-by: line(s)\n");
    - } elsif (!$authorsignoff) {
    + } elsif ($author ne '' && !$authorsignoff) {
    WARN("NO_AUTHOR_SIGN_OFF",
    "Missing Signed-off-by: line by nominal patch author '$author'\n");
    }
    \
     
     \ /
      Last update: 2019-09-12 22:56    [W:2.495 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site