Messages in this thread | | | From | Miguel Ojeda <> | Date | Thu, 12 Sep 2019 16:21:38 +0200 | Subject | Re: [PATCH 00/13] nvdimm: Use more common kernel coding style |
| |
On Thu, Sep 12, 2019 at 4:00 PM Jeff Moyer <jmoyer@redhat.com> wrote: > > Joe Perches <joe@perches.com> writes: > > > Rather than have a local coding style, use the typical kernel style. > > The coding style isn't that different from the core kernel, and it's > still quite readable. I'd rather avoid the churn and the risk of > introducing regressions. This will also make backports to stable more > of a pain, so it isn't without cost. Dan, is this really something you > want to do?
+1 As soon as you get accustomed to have formatting done and enforced automatically, it is great. Other major projects have done so for quite a while now.
If doesn't think it is good enough, please let us know and, if it is close enough, we can look at going for a newer LLVM to match the style a bit more. Also note that one can disable formatting for some sections of code if really needed.
Cheers, Miguel
| |