lkml.org 
[lkml]   [2019]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles
    From
    Date
    On 9/11/19 5:40 PM, Martin K. Petersen wrote:
    > * Do not use custom To: and Cc: for individual patches. We want to see the
    > whole series, even patches that potentially need to go through a different
    > subsystem tree.

    Hi Martin,

    Thanks for having written this summary. This is very helpful. For the
    above paragraph, should it be clarified whether that requirement applies
    to mailing list e-mail addresses only or also to individual e-mail
    addresses? When using git send-email it is easy to end up with different
    cc-lists per patch.

    > * The patch must compile without warnings (make C=1 CF="-D__CHECK_ENDIAN__")
    > and does not incur any zeroday test robot complaints.

    How about adding W=1 to that make command?

    How about existing drivers that trigger tons of endianness warnings,
    e.g. qla2xxx? How about requiring that no new warnings are introduced?

    > * The patch must have a commit message that describes, comprehensively and in
    > plain English, what the patch does.

    How about making this requirement more detailed and requiring that not
    only what has been changed is document but also why that change has been
    made?

    > * Patches which have been obsoleted by a later version will be set to
    > "Superceded" status.

    Did you perhaps mean "Superseded"?

    Thanks,

    Bart.

    \
     
     \ /
      Last update: 2019-09-12 15:32    [W:4.042 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site