Messages in this thread | | | From | Ricardo Ribalda Delgado <> | Date | Thu, 12 Sep 2019 12:51:51 +0200 | Subject | Re: [PATCH v3 3/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA |
| |
HI Jacopo
(Sorry for the late reply, I have been in holidays plus with plenty of family matters)
On Mon, Aug 26, 2019 at 9:39 AM Jacopo Mondi <jacopo@jmondi.org> wrote: > > Hi Ricardo, > > On Fri, Aug 23, 2019 at 02:37:33PM +0200, Ricardo Ribalda Delgado wrote: > > A struct v4l2_area containing the width and the height of a rectangular > > area. > > > > Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org> > > Suggested-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> > > --- > > Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/media/uapi/v4l/vidioc-queryctrl.rst b/Documentation/media/uapi/v4l/vidioc-queryctrl.rst > > index a3d56ffbf4cc..c09d06ef2b08 100644 > > --- a/Documentation/media/uapi/v4l/vidioc-queryctrl.rst > > +++ b/Documentation/media/uapi/v4l/vidioc-queryctrl.rst > > @@ -443,6 +443,12 @@ See also the examples in :ref:`control`. > > - n/a > > - A struct :c:type:`v4l2_ctrl_mpeg2_quantization`, containing MPEG-2 > > quantization matrices for stateless video decoders. > > + * - ``V4L2_CTRL_TYPE_AREA`` > > + - n/a > > Can an area be negative ? > I would set these fields to ">= 0" ">= 1" and ">= 0" respectively. >
Dont min, max and step only make sense for integer controls?
> Thanks > j > > > + - n/a > > + - n/a > > + - A struct :c:type:`v4l2_area`, containing the width and the height > > + of a rectangular area. > > * - ``V4L2_CTRL_TYPE_H264_SPS`` > > - n/a > > - n/a > > -- > > 2.23.0.rc1 > >
| |