Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 12 Sep 2019 10:17:15 +0100 | Subject | Re: [PATCH 3/3] gpio: syscon: Add support for the Xylon LogiCVC GPIOs |
| |
On Tue, Sep 10, 2019 at 4:29 PM Paul Kocialkowski <paul.kocialkowski@bootlin.com> wrote:
> The LogiCVC display hardware block comes with GPIO capabilities > that must be exposed separately from the main driver (as GPIOs) for > use with regulators and panels. A syscon is used to share the same > regmap across the two drivers. > > Since the GPIO capabilities are pretty simple, add them to the syscon > GPIO driver. > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
I'm fine with this for now, but the gpio-syscon driver is now growing big and when you use it you are getting support for a whole bunch of systems you're not running on included in your binary.
We need to think about possibly creating drivers/gpio/syscon and split subdrivers into separate files and config options so that people can slim down to what they actually need.
> + *bit = 1 << offset;
Please do this:
#include <linux/bits.h>
*bit = BIT(offset);
Yours, Linus Walleij
| |