lkml.org 
[lkml]   [2019]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
From
Date
On 9/11/19 4:18 PM, Gabriel C wrote:
> Am Mi., 11. Sept. 2019 um 23:33 Uhr schrieb Jens Axboe <axboe@kernel.dk>:
>>
>> On 9/11/19 3:21 PM, Gabriel C wrote:
>>> Booting with default_ps_max_latency_us >6000 makes the device fail.
>>> Also SUBNQN is NULL and gives a warning on each boot/resume.
>>> $ nvme id-ctrl /dev/nvme0 | grep ^subnqn
>>> subnqn : (null)
>>>
>>> I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop.
>>> To be sure is not a Laptop issue only, I tested the device on
>>> my server board too with the same results.
>>> ( with 2x,4x link on the board and 4x on a PCI-E card ).
>>>
>>> Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
>>> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>>
>> For some reason your commit message is indented. Additionally, your
>> patch is whitespace damaged. So this won't apply anywhere.
>
> Gmail hates me it seems. Sry but I don't have an proper setup on that
> box right now.
> My Laptop died and I try to fix the usual issue for new Laptops on
> this one right now.
> I uploaded the git patch, if you accept it like this. If not I will
> re-send as soon I fix
> this laptop and have git* and other things proper set up.

Use git send-email, it's trivial to use with gmail. That's what I use
and that works fine. If you use gmail (web) for kernel development,
you're going to have a really bad time.

--
Jens Axboe

\
 
 \ /
  Last update: 2019-09-12 00:24    [W:0.024 / U:2.316 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site