lkml.org 
[lkml]   [2019]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4] Staging: exfat: avoid use of strcpy
Date


> On 11 Sep 2019, at 21:06, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Wed, Sep 11, 2019 at 09:53:03PM +0200, Sandro Volery wrote:
>> diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c
>> index da8c58149c35..4336fee444ce 100644
>> --- a/drivers/staging/exfat/exfat_core.c
>> +++ b/drivers/staging/exfat/exfat_core.c
>> @@ -2960,18 +2960,15 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,
>> struct super_block *sb = inode->i_sb;
>> struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
>> struct file_id_t *fid = &(EXFAT_I(inode)->fid);
>> -
>> - if (strlen(path) >= (MAX_NAME_LENGTH * MAX_CHARSET_SIZE))
>> +
>
> You have added a tab here.
>
>> + if (strscpy(name_buf, path, sizeof(name_buf)) < 0)
>> return FFS_INVALIDPATH;
>>
>> - strcpy(name_buf, path);
>> -
>> nls_cstring_to_uniname(sb, p_uniname, name_buf, &lossy);
>> if (lossy)
>> return FFS_INVALIDPATH;
>>
>> - fid->size = i_size_read(inode);
>> -
>> +fid->size = i_size_read(inode);
>
> And you accidentally deleted some white space here.
>
> I use vim, so I have it configured to highlight whitespace at the end of
> a line. I don't remember how it's done now but I googled it for you.
> https://vim.fandom.com/wiki/Highlight_unwanted_spaces


Ugh I'm so sorry I make the most stupid mistakes today.. I was so sure
this time I got it right!
I'll fix it tomorrow.

Thanks,
Sandro V

\
 
 \ /
  Last update: 2019-09-11 21:16    [W:0.028 / U:3.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site