lkml.org 
[lkml]   [2019]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs
Date

Hi,

Richard Cochran <richardcochran@gmail.com> writes:
> On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote:
>
>> case PTP_PEROUT_REQUEST:
>> + case PTP_PEROUT_REQUEST2:
>
> ...
>
>> + if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) ||
>> + req.perout.rsv[0] || req.perout.rsv[1] ||
>> + req.perout.rsv[2] || req.perout.rsv[3]) &&
>> + cmd == PTP_PEROUT_REQUEST2) {
>> + err = -EINVAL;
>> + break;
>
> ...
>
>> +/*
>> + * Bits of the ptp_perout_request.flags field:
>> + */
>> +#define PTP_PEROUT_VALID_FLAGS (~0)
>
> I think you meant (0) here, or I am confused...

Argh. What a brain fart!

Sorry about that. I'll go fix that ASAP.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-09-11 08:09    [W:0.037 / U:10.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site