lkml.org 
[lkml]   [2019]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] cpupower : Handle set and info subcommands for powerpc
From
Date
On 9/11/19 3:54 AM, Abhishek Goel wrote:
> Cpupower tool has set and info options which are not being used by
> POWER machines. For powerpc, we will return directly for these two
> subcommands. This removes the ambiguous error message while using set
> option in case of power systems.

What is the error message you see? Please include it in the commit log.

>
> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
> ---
> tools/power/cpupower/utils/cpupower-info.c | 5 +++++
> tools/power/cpupower/utils/cpupower-set.c | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/tools/power/cpupower/utils/cpupower-info.c b/tools/power/cpupower/utils/cpupower-info.c
> index 4c9d342b70ff..674b707a76af 100644
> --- a/tools/power/cpupower/utils/cpupower-info.c
> +++ b/tools/power/cpupower/utils/cpupower-info.c
> @@ -39,6 +39,11 @@ int cmd_info(int argc, char **argv)
> } params = {};
> int ret = 0;
>
> + #ifdef __powerpc__
> + printf(_("Cannot read info as system does not support performance bias setting\n"));
> + return 0;
> + #endif
> +

I am not in favor of bailing out this early with this ifdef switch.
I would rather see this checked somehow(?) when the ambiguous error
happens.

> setlocale(LC_ALL, "");
> textdomain(PACKAGE);
>
> diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
> index 3cd95c6cb974..c95b29278780 100644
> --- a/tools/power/cpupower/utils/cpupower-set.c
> +++ b/tools/power/cpupower/utils/cpupower-set.c
> @@ -41,6 +41,11 @@ int cmd_set(int argc, char **argv)
> int perf_bias = 0;
> int ret = 0;
>
> + #ifdef __powerpc__
> + printf(_("System does not support performance bias setting\n"));
> + return 0;
> + #endif
> +

Same here.

> setlocale(LC_ALL, "");
> textdomain(PACKAGE);
>
>

thanks,
-- Shuah

\
 
 \ /
  Last update: 2019-09-11 12:12    [W:0.056 / U:0.904 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site