lkml.org 
[lkml]   [2019]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] arm64: dts: imx8mm: Remove incorrect fallback compatible for ocotp
Date
Hi, Daniel

> On 11/09/2019 16:24, Anson Huang wrote:
> > Compared to i.MX7D, i.MX8MM has different ocotp layout, so it should
> > NOT use "fsl,imx7d-ocotp" as ocotp's fallback compatible, remove it.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index 5f9d0da..7c4dcce 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -426,7 +426,7 @@
> > };
> >
> > ocotp: ocotp-ctrl@30350000 {
> > - compatible = "fsl,imx8mm-ocotp", "fsl,imx7d-
> ocotp", "syscon";
> > + compatible = "fsl,imx8mm-ocotp", "syscon";
> > reg = <0x30350000 0x10000>;
> > clocks = <&clk IMX8MM_CLK_OCOTP_ROOT>;
> > /* For nvmem subnodes */
>
> Why not fold the two patches?

For i.MX8MM, it just removes the incorrect fallback compatible, for i.MX8MN, it needs
to replace the incorrect fallback compatible in order to support SoC UID read, so I think
this should be 2 separate patch?

Thanks,
Anson.
\
 
 \ /
  Last update: 2019-09-11 11:07    [W:0.033 / U:0.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site