Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 11 Sep 2019 11:29:10 +0300 | Subject | Re: [PATCH v4 06/14] software node: get rid of property_set_pointer() |
| |
On Wed, Sep 11, 2019 at 8:15 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > Instead of explicitly setting values of integer types when copying > property entries lets just copy entire value union when processing > non-array values. > > When handling array values assign the pointer there using the newly > introduced "raw" pointer union member. This allows us to remove > property_set_pointer(). > > In property_get_pointer() we do not need to handle each data type > separately, we can simply return either the raw pointer or pointer to > values union.
Same as before, typechecking is good thing to have for my point of view. Others may have different opinions.
-- With Best Regards, Andy Shevchenko
| |