lkml.org 
[lkml]   [2019]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] ARM: dts: realtek: Add support for Realtek RTD16XX evaluation board
Date
> Subject: Re: [PATCH] ARM: dts: realtek: Add support for Realtek RTD16XX
> evaluation board
>
> On Thu, Sep 5, 2019 at 10:10 AM <jamestai.sky@gmail.com> wrote:
>
> > +
> > +/ {
> > + model= "Realtek Mjolnir Evaluation Board";
> > + model_hex= <0x00000653>;
>
> The 'mode_hex' property is rather unusual, please drop that for now.

I will remove the 'mode_hex' property in new version patch.

>
> > + chosen {
> > + bootargs = "console=ttyS0,115200 earlycon";
> > + };
> > +
> > + memory@0 {
> > + device_type = "memory";
> > + reg = <0x0 0x0 0x0 0x80000000>;
> > + };
> > +
> > + uart0: serial0@98007800 {
> > + compatible = "snps,dw-apb-uart";
> > + reg = <0x0 0x98007800 0x0 0x400>,
> > + <0x0 0x98007000 0x0 0x100>;
> > + reg-shift = <2>;
> > + reg-io-width = <4>;
> > + interrupts = <0 68 4>;
> > + clock-frequency = <27000000>;
> > + status = "okay";
> > + };
>
> This looks like an on-chip uart. Please move that into rtd16xx.dtsi instead, and
> just mark it as 'status="disabled"' there if there are multiple uarts (and add the
> other ones as well), then enable it for the board here.

Yes. It is on-chip uart.
I will move uart0 into 'rtd16xx.dtsi' and mark it as 'status="disabled" '.

> There should also be an 'aliases'. You normally also want to add

I will add aliases in new version patch.

> aliases {
> serial0 = &uart0;
> };
>
> chosen {
> stdout-path= "serial0:115200n8"
> };
>
> in the board file to make earlycon work right.

OK, I understand.

> Arnd
>
> ------Please consider the environment before printing this e-mail.
\
 
 \ /
  Last update: 2019-09-11 10:07    [W:0.054 / U:38.112 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site