lkml.org 
[lkml]   [2019]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net 1/2] sctp: remove redundant assignment when call sctp_get_port_local
    On Tue, Sep 10, 2019 at 03:13:42PM +0800, Mao Wenan wrote:
    > There are more parentheses in if clause when call sctp_get_port_local
    > in sctp_do_bind, and redundant assignment to 'ret'. This patch is to
    > do cleanup.
    >
    > Signed-off-by: Mao Wenan <maowenan@huawei.com>
    > ---
    > net/sctp/socket.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/net/sctp/socket.c b/net/sctp/socket.c
    > index 9d1f83b10c0a..766b68b55ebe 100644
    > --- a/net/sctp/socket.c
    > +++ b/net/sctp/socket.c
    > @@ -399,9 +399,8 @@ static int sctp_do_bind(struct sock *sk, union sctp_addr *addr, int len)
    > * detection.
    > */
    > addr->v4.sin_port = htons(snum);
    > - if ((ret = sctp_get_port_local(sk, addr))) {
    > + if (sctp_get_port_local(sk, addr))
    > return -EADDRINUSE;

    sctp_get_port_local() returns a long which is either 0,1 or a pointer
    casted to long. It's not documented what it means and neither of the
    callers use the return since commit 62208f12451f ("net: sctp: simplify
    sctp_get_port").

    Probably it should just return a bool?

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2019-09-10 20:59    [W:2.464 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site