Messages in this thread | | | Date | Tue, 10 Sep 2019 08:44:52 -0700 | From | Richard Cochran <> | Subject | Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs |
| |
On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote:
> case PTP_PEROUT_REQUEST: > + case PTP_PEROUT_REQUEST2:
...
> + if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) || > + req.perout.rsv[0] || req.perout.rsv[1] || > + req.perout.rsv[2] || req.perout.rsv[3]) && > + cmd == PTP_PEROUT_REQUEST2) { > + err = -EINVAL; > + break;
...
> +/* > + * Bits of the ptp_perout_request.flags field: > + */ > +#define PTP_PEROUT_VALID_FLAGS (~0)
I think you meant (0) here, or I am confused...
Thanks, Richard
| |