Messages in this thread | | | Date | Tue, 10 Sep 2019 12:22:33 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS] |
| |
On Tue, Sep 10, 2019 at 11:46:56AM +0300, Sakari Ailus wrote: > There are no in-kernel %p[fF] users left. Convert the traceevent tool, > too, to align with the kernel.
> function. The _tep_ argument is the trace event parser context. The _name_ is > -the name of the function, the string is copied internally. The _addr_ is > -the start address of the function. The _mod_ is the kernel module > -the function may be in (NULL for none). > +the name of the function, the string is copied internally. The _addr_ is the > +start address of the function. The _mod_ is the kernel module the function may > +be in (NULL for none).
This seems a churn of reformatting.
> - if (asprintf(&format, "%%pf: (NO FORMAT FOUND at %llx)\n", addr) < 0) > + if (asprintf(&format, "%%ps: (NO FORMAT FOUND at %llx)\n", > + addr) < 0)
Splitting line also seems a churn to me. But this one is up to maintainers.
Other than above, looks good to me, thanks!
-- With Best Regards, Andy Shevchenko
| |