Messages in this thread | | | Subject | Re: [PATCH] sh: Drop -Werror from kernel Makefile | From | "Gustavo A. R. Silva" <> | Date | Fri, 9 Aug 2019 16:36:01 -0500 |
| |
Hi Guenter,
On 8/9/19 2:56 PM, Guenter Roeck wrote: > On Sun, Aug 04, 2019 at 11:24:41PM -0400, Rich Felker wrote: >> On Sun, Aug 04, 2019 at 07:14:23PM -0700, Guenter Roeck wrote: >>> Since commit a035d552a93b ("Makefile: Globally enable fall-through >>> warning"), all sh builds fail with errors such as >>> >>> arch/sh/kernel/disassemble.c: In function 'print_sh_insn': >>> arch/sh/kernel/disassemble.c:478:8: error: this statement may fall through >>> >>> Since this effectively disables all build and boot tests for the >>> architecture, let's drop -Werror from the sh kernel Makefile until >>> the problems are fixed. >>> >>> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com> >>> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> >> Acked-by: Rich Felker <dalias@libc.org> >> > Any chance to get this or a similar patch applied soon ? All sh builds > in mainline and -next are still broken. >
If no one cares, I can add it to my tree and include it in my pull-request for 5.3-rc4.
I would just need your Tested-by.
Thanks -- Gustavo
> Thanks, > Guenter > >>> --- >>> arch/sh/kernel/Makefile | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/arch/sh/kernel/Makefile b/arch/sh/kernel/Makefile >>> index 59673f8a3379..ef65f0625c6c 100644 >>> --- a/arch/sh/kernel/Makefile >>> +++ b/arch/sh/kernel/Makefile >>> @@ -47,5 +47,3 @@ obj-$(CONFIG_DWARF_UNWINDER) += dwarf.o >>> obj-$(CONFIG_PERF_EVENTS) += perf_event.o perf_callchain.o >>> obj-$(CONFIG_DMA_NONCOHERENT) += dma-coherent.o >>> obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o >>> - >>> -ccflags-y := -Werror >>> -- >>> 2.7.4
| |