lkml.org 
[lkml]   [2019]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: linux-next: build failure after merge of the sound tree
    On Fri, 09 Aug 2019 04:54:58 +0200,
    Stephen Rothwell wrote:
    >
    > Hi all,
    >
    > After merging the sound tree, today's linux-next build (arm
    > multi_v7_defconfig) failed like this:
    >
    > sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_read':
    > sound/hda/hdac_bus.c:228:6: error: implicit declaration of function 'readl'; did you mean 'd_real'? [-Werror=implicit-function-declaration]
    > v = readl(aligned_addr);
    > ^~~~~
    > d_real
    > sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_write':
    > sound/hda/hdac_bus.c:244:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
    > writel(v, aligned_addr);
    > ^~~~~~
    >
    > Caused by commit
    >
    > 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
    >
    > I have applied the following patch for today:
    >
    > From: Stephen Rothwell <sfr@canb.auug.org.au>
    > Date: Fri, 9 Aug 2019 12:50:25 +1000
    > Subject: [PATCH] ALSA: hda: readl/writel need linux/io.h
    >
    > Fixes: 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
    > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
    > ---
    > sound/hda/hdac_bus.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c
    > index dc2523ef7d98..cd25e2b3f7f2 100644
    > --- a/sound/hda/hdac_bus.c
    > +++ b/sound/hda/hdac_bus.c
    > @@ -4,6 +4,7 @@
    > */
    >
    > #include <linux/init.h>
    > +#include <linux/io.h>
    > #include <linux/device.h>
    > #include <linux/module.h>
    > #include <linux/export.h>

    Thanks, it's obviously a right fix.

    I applied it on top of topic/hda-bus-ops-cleanup branch branch.
    Mark, feel free to pull it into yours again.


    Takashi

    \
     
     \ /
      Last update: 2019-08-09 07:57    [W:4.272 / U:0.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site