Messages in this thread | | | Date | Thu, 08 Aug 2019 22:32:47 -0700 (PDT) | Subject | Re: [PATCH net-next] fq_codel: remove set but not used variables 'prev_ecn_mark' and 'prev_drop_count' | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Thu, 08 Aug 2019 22:31:36 -0700 (PDT)
> From: YueHaibing <yuehaibing@huawei.com> > Date: Wed, 7 Aug 2019 21:10:55 +0800 > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> net/sched/sch_fq_codel.c: In function fq_codel_dequeue: >> net/sched/sch_fq_codel.c:288:23: warning: variable prev_ecn_mark set but not used [-Wunused-but-set-variable] >> net/sched/sch_fq_codel.c:288:6: warning: variable prev_drop_count set but not used [-Wunused-but-set-variable] >> >> They are not used since commit 77ddaff218fc ("fq_codel: Kill >> useless per-flow dropped statistic") >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Do you even compile test this stuff? > > CC [M] net/sched/sch_fq_codel.o > net/sched/sch_fq_codel.c: In function ‘fq_codel_dequeue’: > net/sched/sch_fq_codel.c:309:42: error: ‘prev_drop_count’ undeclared (first use in this function); did you mean ‘page_ref_count’?
Never mind, this is my fault.
I was build testing the patch on the wrong tree, I'm very sorry.
| |