lkml.org 
[lkml]   [2019]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put
On Fri, 09 Aug 2019 09:46:43 +0200,
Tony Lindgren wrote:
>
> * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > On Fri, 09 Aug 2019 09:00:03 +0200,
> > Tony Lindgren wrote:
> > >
> > > Hi,
> > >
> > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > snd_soc_component_get/put()") causes a regression where trying
> > > to rmmod a codec driver fails with module is in use error after
> > > rmmod of snd-soc-audio-graph-card for example.
> > >
> > > Any ideas what goes wrong there?
> >
> > There is an obvious typo: soc_cleanup_component() should call
> > snd_soc_component_module_put_when_remove() instead of *_close().
>
> Making that change locally seems to fix it thanks.

... and it was already fixed in the later commit 0e36f36b04e7
"ASoC: soc-core: fix module_put() warning in soc_cleanup_component".


Takashi

\
 
 \ /
  Last update: 2019-08-09 10:23    [W:0.055 / U:1.556 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site