Messages in this thread | | | Subject | Re: [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...) | From | Neil Armstrong <> | Date | Thu, 8 Aug 2019 16:12:30 +0200 |
| |
On 25/06/2019 01:24, Kevin Hilman wrote: > Julien Masson <jmasson@baylibre.com> writes: > >> This patch series aims to clean-up differents parts of the drm meson >> code source. >> >> Couple macros have been defined and used to set several registers >> instead of using magic constants. >> >> I also took the opportunity to: >> - add/remove/update comments >> - remove useless code >> - minor fix/improvment > > Nice set of cleanups, thanks! I especially like the extra in-code > comments. > > Could you also add to the cover-letter how this was tested, and on what > platforms so we know it's not going to introduce any regressions. > > Thanks, > > Kevin >
Apart the wrong magic value in patch 4 that I'll fix while applying, Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
I'll run a few tests on all the supported SoC versions: - GXBB - GXL - GXM - G12A/G12B
and push to drm-misc-next.
Neil
| |