Messages in this thread | | | Date | Wed, 7 Aug 2019 22:23:46 -0700 | From | Jesse Brandeburg <> | Subject | Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring |
| |
On Wed, 31 Jul 2019 09:38:42 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> There is no good reason to use GFP_ATOMIC here. Other memory allocations > are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and > 'kzalloc()' in 'et131x_rx_dma_memory_alloc()') > > Use GFP_KERNEL which should be enough. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Sure, but generally I'd say GFP_ATOMIC is ok if you're in an init path and you can afford to have the allocation thread sleep while memory is being found by the kernel.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
| |